release0.3_post3_PR3

In this pull request, I tried to write some test. I come back to my first open source project filer to find something to work on.

First, I tried to fix my 1st pull request from this project that I have worked on (add a test for fs.promises.unlink). I have made two commits and pushed them.

Then, I find something similar to create a new pull request (add fs.promises.write test). I didn't create an issue for this PR. My professor said that it's fine if we make a PR without creating an issue.

These commits are pushed but there are some conflicts and need to resolve. I don't want to do it by myself. I will come to class and ask my professor for help.

Comments

Post a Comment

Popular posts from this blog

OSD600_lab1

Requirements This lab will introduce you to blogging, the CDOT wiki, and node's fs module. Here is a checklist of what needs to be done (see below for more details): Create a CDOT wiki account Create a Blog account Add your Blog's RSS Feed URL to the CDOT Wiki's Planet Feed List Research a node.js fs module feature Write a short post about how to use this feature in the various supported Add your Name and Blog post's URL to the table at the end of this lab Research a node.js fs feature 1. /***************************************************************************  *  fs.unlink(path, callback)                                                            ...
Read more

OSD600_Release0.2 _Hacktoberfest _Post5

Image
Project:  JSON Movie Collection Issue:  Add "Queen of Katwe" movie in 2016 #2133 Pull Request:  Fix #2133 Added "Queen of Katwe" movie #2142 In my last pull request of my 5th pull requests for this month, I have worked on this JSON Movie Collection project. This is a collection of movies and actors separated by year and written in json file format. I watched Queen of Katwe movie recently and I like it. It is one of the famous Disney movies and get lots of award in 2016. I checked the 2016 movie folder and noted this movie has not been on the list yet. Then, I filed an issue, asked to work on it, made a commit and made a pull request. I hope I can get it "merged" soon. My issue, pull request and file changed in GitHub:
Read more

release0.3_post2_PR1_PR2

Image
In this second blog, I want to talk about my first two internal PRs about the  SenecaBlackboardExtension  project. This project is about how to make the  Seneca Black Board website  more friendly through Google Chrome Extension. In my first PR, I added a Seneca Help link in the sign in website. The purpose of this issue is to help some new coming students who first time use this black board. Everyone can find some tips on this link about how to use Seneca Black Board. I want to put this link in the top right side beside the welcome link, so it will be easy to see. However, I come up with a new idea putting it into the College Services box when I saw the code. Some of my friends already added lots of links into this box. It is also right if all services links are set in one area. Issue:  https://github.com/yevseytsev/SenecaBlackboardExtension/issues/12 PR:  https://github.com/yevseytsev/SenecaBlackboardExtension/pull/33 In my second PR, I modified th...
Read more