OSD600-Release0.4-PR1-blog1

My planning in this release 0.4 is to have one PR of an internal project and two PRs of an  external project.
  1. Internal project: Seneca Student Resume/Portfolio Static Site Generator
  2. External project: Node.js
In this blog, I want to talk about my first PR in the Node.js project. This project is welcome the new learning node language contributors, so I want to give a try. I have learned the whole process of how to setup security key and push an PR with personal access token in command line that I have not done in my previous PRs.

First, I had to learn a little bit about node language for beginner in YouTube. Then, I followed this Node Todo to start working on this project. I have viewed some commits that recommended in the Node Todo website, learned how some contributors fixed the issue. After that, I found an issue in another file likes this commit. I followed this instruction to build and run the test in my local machine. It will take around 30 minutes to finish these tasks because node is a huge project. Then, I made a first commit and pushed it that was not following this commit guidelines and I got a result one check failed. Next, one of the reviewers gave me a suggestion. He stated that it will be better if I remove the extra blank line. During the time making a second commit, I got some pop up windows when signing in to GitHub website to set the 2FA key. Then, I did it. After I set the security key, when I pushed the second commit in the command line, I have been asked for a password. I did not know about it. I did some research and followed this link to set up my password. Then, I pushed the second commit and it was not following this commit guidelines again. One more check failed about the commit. Then, I talked to my classmate, Jeffrey Espiritu, about my PR. He took a look and gave me a nice suggestion why I don't do the rebase to combine two commits and create a new shorter commit that is NOT longer 72 characters. I did not count my commits characters. Then, I need to do the rebase.





I can see the test passed or failed in this link  after I made a pull request



To sum up, after this PR, I learned lots of things like what I said. One more thing, I tried to communicate with my professor on slack , my classmate to get help from them. This is the important thing that I rarely do, but I tried to do it this time. Awesome!!!



Project: https://github.com/nodejs/node 

PR: https://github.com/nodejs/node/pull/24584































Comments











Post a Comment























Popular posts from this blog









OSD600_lab1





















Requirements    This lab will introduce you to blogging, the CDOT wiki, and node's fs module.  Here is a checklist of what needs to be done (see below for more details):     Create a CDOT wiki account   Create a Blog account   Add your Blog's RSS Feed URL to the CDOT Wiki's Planet Feed List   Research a node.js fs module feature   Write a short post about how to use this feature in the various supported   Add your Name and Blog post's URL to the table at the end of this lab      Research a node.js fs feature    1.  /***************************************************************************   *  fs.unlink(path, callback)                                                            ...








Read more










OSD600_Release0.2 _Hacktoberfest _Post5




















Image







  Project:  JSON Movie Collection  Issue:  Add "Queen of Katwe" movie in 2016 #2133  Pull Request:  Fix #2133 Added "Queen of Katwe" movie #2142    In my last pull request of my 5th pull requests for this month, I have worked on this JSON Movie Collection project. This is a collection of movies and actors separated by year and written in json file format. I watched Queen of Katwe movie recently and I like it. It is one of the famous Disney movies and get lots of award in 2016. I checked the 2016 movie folder and noted this movie has not been on the list yet. Then, I filed an issue, asked to work on it, made a commit and made a pull request. I hope I can get it "merged" soon.     My issue, pull request and file changed in GitHub:                          








Read more










release0.3_post2_PR1_PR2




















Image







In this second blog, I want to talk about my first two internal PRs about the  SenecaBlackboardExtension  project. This project is about how to make the  Seneca Black Board website  more friendly through Google Chrome Extension.   In my first PR, I added a Seneca Help link in the sign in website. The purpose of this issue is to help some new coming students who first time use this black board. Everyone can find some tips on this link about how to use Seneca Black Board. I want to put this link in the top right side beside the welcome link, so it will be easy to see. However, I come up with a new idea putting it into the College Services box when I saw the code. Some of my friends already added lots of links into this box. It is also right if all services links are set in one area.    Issue:  https://github.com/yevseytsev/SenecaBlackboardExtension/issues/12  PR:  https://github.com/yevseytsev/SenecaBlackboardExtension/pull/33   In my second PR, I modified th...








Read more