OSD600-Release0.4-PR1-blog1

My planning in this release 0.4 is to have one PR of an internal project and two PRs of an  external project.
  1. Internal project: Seneca Student Resume/Portfolio Static Site Generator
  2. External project: Node.js
In this blog, I want to talk about my first PR in the Node.js project. This project is welcome the new learning node language contributors, so I want to give a try. I have learned the whole process of how to setup security key and push an PR with personal access token in command line that I have not done in my previous PRs.

First, I had to learn a little bit about node language for beginner in YouTube. Then, I followed this Node Todo to start working on this project. I have viewed some commits that recommended in the Node Todo website, learned how some contributors fixed the issue. After that, I found an issue in another file likes this commit. I followed this instruction to build and run the test in my local machine. It will take around 30 minutes to finish these tasks because node is a huge project. Then, I made a first commit and pushed it that was not following this commit guidelines and I got a result one check failed. Next, one of the reviewers gave me a suggestion. He stated that it will be better if I remove the extra blank line. During the time making a second commit, I got some pop up windows when signing in to GitHub website to set the 2FA key. Then, I did it. After I set the security key, when I pushed the second commit in the command line, I have been asked for a password. I did not know about it. I did some research and followed this link to set up my password. Then, I pushed the second commit and it was not following this commit guidelines again. One more check failed about the commit. Then, I talked to my classmate, Jeffrey Espiritu, about my PR. He took a look and gave me a nice suggestion why I don't do the rebase to combine two commits and create a new shorter commit that is NOT longer 72 characters. I did not count my commits characters. Then, I need to do the rebase.





I can see the test passed or failed in this link  after I made a pull request



To sum up, after this PR, I learned lots of things like what I said. One more thing, I tried to communicate with my professor on slack , my classmate to get help from them. This is the important thing that I rarely do, but I tried to do it this time. Awesome!!!



Project: https://github.com/nodejs/node 

PR: https://github.com/nodejs/node/pull/24584































Comments











Post a Comment























Popular posts from this blog









release0.3_summary




















Image







In this release 0.3, I have chosen and got involved in two projects, one internal project SenecaBlackboardExtension  and one external project filer . I tried to find some different kind of work, such as adding a link, fixing a bug, modifying a document and writing test. In addition to, I learned about new software Gource  (more information on GitHub:  https://github.com/acaudwell/Gource) . Gource will create a 3D animated tree for source control repositories. Its 3D visualization will show the repository in the centre.  You can see all contributors' name, directories and branches in this tree. I have created one for my SenecaBlackboardExtension project.     For first PR, I have added a link, Seneca Help link, in the sign in page.   PR: https://github.com/yevseytsev/SenecaBlackboardExtension/pull/33   I added this link because I want everyone can get help easier from sign in page.     For second PR, I had been doing a little bit work. I modified the homepage-guest.js file. The code 








Read more










OSD600-Release0.4-PR2-blog2





















In this Pull Request, I have worked on this  bootstrap-slider  project. This is another external project that I have joined for this release 0.4.   PR:  https://github.com/seiyria/bootstrap-slider/pull/886   I used HTLM and CSS language to build a table to store all slider examples. This page is really long, so I created some links to link to the specified example parts. Also, I created a link in each example parts to link back to the top. It will be easy for everyone to view this page.   I had some problems about the write access in the first time, so I could not run it in my local machine. After I reviewed some feedback of the reviewer, I run these commands to test it   npm install node node_modules/grunt-cli/bin/grunt dev          To sum up, this page is showing lots of bootstrap slider options that I can learn to prepare for another course project for next semester.








Read more










OSD600_Release0.2 _Hacktoberfest _Summary




















Image







During this October, going through Hacktoberfest, working on open sources code, and making five pull requests on GitHub were my learning experience so far. I have tried to work on some projects that I didn't know before, find some issues and make pull requests. A lot of research have been done step by step to finish all of them. Also, dealing with git commands and setting environment to work on the issues were really more difficult than I thought.     In my first pull request, I found something to work on this  Interesting-Open-Source-Projects  link. I wanted to work on Android application, so I came to the list and checked some starter projects. On the issues list of Minimal-Todo project, there are many translation supports, so I added Vietnamese translation support issue, and asked permission to work on. I spent around 2 hours to upgrade my Android Studio to test the app on my local machine. Someone already made the issue about the error of setting this environment  on GitHub, so








Read more